fix(ext/node): http2session ready state #25143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com>
|
|
satyarohith
approved these changes
Aug 22, 2024
crowlKats
pushed a commit
to crowlKats/deno
that referenced
this pull request
Aug 22, 2024
Fixes denoland#25142 Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com> (cherry picked from commit 79c7db3)
|
@satyarohith Should we add a test for this? |
Sure. I verified that the flag is set correctly but didn't ask for a test to avoid bloating the suite. |
|
We can never have enough tests. The more tests we have, the easier it will be to do refactorings in the future as it allows us to be more confident that we didn't break something accidentally in the process. |
|
If you can point me to the right file to write a test in, I can attempt to add one! |
|
Looks like https://github.com/denoland/deno/blob/main/tests/unit_node/http2_test.ts is the right file, let me try to get one in there... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25142